iPhone 12 Pro vs iPhone 18 Pro: should you upgrade?

If you're buying new, get the iPhone 18 Pro. The iPhone 12 Pro is no longer sold by Apple.

Brand new, so you get the longest run of updates and full resale value.

The iPhone 18 Pro is 6 years newer, so it will get software updates for longer and holds its value better. If your iPhone 12 Pro still works well, there's no rush, but don't buy one new.